[8.x] Allows Stringable objects as middleware.

[DarkGhostHunter]

What?

You can use Stringable objects into middleware declaration. These will be transformed into a string automatically. Pretty much like a Rule::exists() works.

use Illuminate\Support\Facades\Route;
use App\Http\Middleware\Helpers\Subscribe;

Route::get('library', 'LibraryController@index')
    ->middleware(Subscribed::to('premium')->can('listen')->except('admin'));

Why?

This allows to use helpers for middleware that contain multiple parameters into one fluid sentence. Useful for packages that have middleware with a parameters that should be overridden per-route basis.

For example, the built-in ThrottlesRequest middleware which has 3 parameters. Using a Stringable-based helper, we can transform the declaration into something more understandable forwarding the call to the helper.

// Before
Route::get('library', 'LibraryController@index')
     ->middleware('throttle:120,5,download-book');

// After
Route::get('library', 'LibraryController@index')
     ->middleware(ThrottleRequests::as('download-book')->for(5)->max(120));

Also works on Resource routes:

 $this->router->resource('song', 'SongController::class')
                     ->only('index')
                     ->middleware(['auth', ThrottleRequests::as('download-book')->for(5)->max(120)]);

BC?

• No, it's adds a checks if the middleware is not a string and casts it to a string.

[taylorotwell]

Does this work for route groups, etc?

Route::middleware()->group(fn);

[DarkGhostHunter]

Does this work for route groups, etc?

Route::middleware()->group(fn);

Yes. I added a new test to be 200% sure.

[DarkGhostHunter]

Test stalled (HUGE THANKS WINDOWS). Can someone make a re-run?

[taylorotwell]

I may need to revert this already @DarkGhostHunter

This simple test doesn't even work locally:

[DarkGhostHunter]

What does the stack trace says?

Weird since supposedly the value is casted as a string on ingress. If it's an array, it will do it for each member.

[taylorotwell]

Try it in your own application so we don't have to debug over GH issues.

[DarkGhostHunter]

Asap. Italo Baeza C.

…

El 02-11-2021, a la(s) 12:32, Taylor Otwell ***@***.***> escribió:  Try it in your own application so we don't have to debug over GH issues. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[DarkGhostHunter]

Got it. Forgot to add it to the Route instance. Route::middleware() will work, but Route::get()->middleware() will not as it uses the Route instance itself instead of the registrar.

Adding a PR to fix this...

[DarkGhostHunter]

Fixed in #39449

[mingyoung]

@DarkGhostHunter

framework/src/Illuminate/Routing/RouteRegistrar.php

Lines 108 to 112 in dec9524

	if ($key === 'middleware') {
	foreach ($value as $index => $middleware) {
	$value[$index] = (string) $middleware;
	}
	}

It will throw when I use closure middleware.

[DarkGhostHunter]

Docblock states only array or string are accepted.

[lupinitylabs]

I ran into the same issue like @mingyoung using closure middleware.
I have no idea where I picked it up from, but it's obviously neither in the documentation nor in the tests... 🤷

[DarkGhostHunter]

PHPDocs states only string or array are permitted. Using Closures are not supported. There are not even tests for that. Italo Baeza C.

…

El 29-11-2021, a la(s) 09:35, Oliver Matla ***@***.***> escribió:  I ran into the same issue like @mingyoung using closure middleware. I have no idea where I picked it up from, but it's obviously neither in the documentation nor in the tests... 🤷 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[lupinitylabs]

I think that is, word by word, exactly what I wrote 😅