Skip to content

[9.x] Remove hard coded Menlo font from dd source file function output #44331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[9.x] Remove hard coded Menlo font from dd source file function output #44331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Http/HtmlDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ protected function getDumpSourceContent()
);
}

return sprintf('<span style="color: #A0A0A0; font-family: Menlo"> // %s</span>', $source);
return sprintf('<span style="color: #A0A0A0;"> // %s</span>', $source);
}

/**
Expand Down
14 changes: 7 additions & 7 deletions tests/Foundation/Http/HtmlDumperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function testString()
{
$output = $this->dump('string');

$expected = "string</span>\"<span style=\"color: #A0A0A0; font-family: Menlo\"> // app/routes/console.php:18</span>\n</pre>";
$expected = "string</span>\"<span style=\"color: #A0A0A0;\"> // app/routes/console.php:18</span>\n</pre>";

$this->assertStringContainsString($expected, $output);
}
Expand All @@ -34,7 +34,7 @@ public function testInteger()
{
$output = $this->dump(1);

$expected = "1</span><span style=\"color: #A0A0A0; font-family: Menlo\"> // app/routes/console.php:18</span>\n</pre>";
$expected = "1</span><span style=\"color: #A0A0A0;\"> // app/routes/console.php:18</span>\n</pre>";

$this->assertStringContainsString($expected, $output);
}
Expand All @@ -43,7 +43,7 @@ public function testFloat()
{
$output = $this->dump(1.1);

$expected = "1.1</span><span style=\"color: #A0A0A0; font-family: Menlo\"> // app/routes/console.php:18</span>\n</pre>";
$expected = "1.1</span><span style=\"color: #A0A0A0;\"> // app/routes/console.php:18</span>\n</pre>";

$this->assertStringContainsString($expected, $output);
}
Expand All @@ -52,7 +52,7 @@ public function testArray()
{
$output = $this->dump(['string', 1, 1.1, ['string', 1, 1.1]]);

$expected = '<samp data-depth=1 class=sf-dump-expanded><span style="color: #A0A0A0; font-family: Menlo"> // app/routes/console.php:18</span>';
$expected = '<samp data-depth=1 class=sf-dump-expanded><span style="color: #A0A0A0;"> // app/routes/console.php:18</span>';

$this->assertStringContainsString($expected, $output);
}
Expand All @@ -61,7 +61,7 @@ public function testBoolean()
{
$output = $this->dump(true);

$expected = "true</span><span style=\"color: #A0A0A0; font-family: Menlo\"> // app/routes/console.php:18</span>\n</pre>";
$expected = "true</span><span style=\"color: #A0A0A0;\"> // app/routes/console.php:18</span>\n</pre>";

$this->assertStringContainsString($expected, $output);
}
Expand All @@ -73,7 +73,7 @@ public function testObject()

$output = $this->dump($user);

$expected = '<samp data-depth=1 class=sf-dump-expanded><span style="color: #A0A0A0; font-family: Menlo"> // app/routes/console.php:18</span>';
$expected = '<samp data-depth=1 class=sf-dump-expanded><span style="color: #A0A0A0;"> // app/routes/console.php:18</span>';

$this->assertStringContainsString($expected, $output);
}
Expand All @@ -82,7 +82,7 @@ public function testNull()
{
$output = $this->dump(null);

$expected = "null</span><span style=\"color: #A0A0A0; font-family: Menlo\"> // app/routes/console.php:18</span>\n</pre>";
$expected = "null</span><span style=\"color: #A0A0A0;\"> // app/routes/console.php:18</span>\n</pre>";

$this->assertStringContainsString($expected, $output);
}
Expand Down