Prevent contextual bindings from following stale aliases #56495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macropay-solutions
pushed a commit
to macropay-solutions/maravel-framework
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving contextual bindings, the container does a reverse lookup on aliases: it checks to see if there is a contextual binding on an alias of the interface it needs an instance of.
$container->abstractAliasesis a reverse mapping of interfaces to their aliases that supports this lookup. Because$container->alias()does not remove old entries fromabstractAliases, the container ends up checking whether there ever has been an alias to the current interface, not whether there currently is such an alias.This PR adds a test for the correct behaviour and a fix that makes the test pass.
There are some unrelated failing tests.