[12.x] Add missing "nil" option to union type for Str::isUuid() $version parameter
#56557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't think, this test failure is caused by my change: Run vendor/bin/phpstan --configuration="phpstan.types.neon.dist" --no-progress
Error: Unreachable statement - code above always terminates.
Error: Unreachable statement - code above always terminates.
------ -------------------------------------------------------
Line Support/Helpers.php
------ -------------------------------------------------------
47 Unreachable statement - code above always terminates.
🪪 deadCode.unreachable
66 Unreachable statement - code above always terminates.
🪪 deadCode.unreachable
------ -------------------------------------------------------
Error: [ERROR] Found 2 errors
Error: Process completed with exit code 1. |
shaedrich
deleted the
fix-str-is-uuid-phpdoc-block-version-param-union-type
branch
Contributor
|
I will leave that here: https://datatracker.ietf.org/doc/html/rfc4122#section-4.1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.