[12.x] Improve queue:prune-failed tests coverage
#56732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the test coverage for the
queue:prune-failedcommand, focusing specifically on scenarios involving the--hoursoption. Previously, tests only verified pruning at the date level. The new tests ensure precise pruning at the hour level, covering important edge cases.Benefits:
Edge case handling: The prune logic uses a strict
less thancomparison. For example, if a job failed at11:00and pruning is performed at11:00, only jobs that failed before11:00are deleted. These tests verify that behavior.Coverage: Tests verify pruning behavior for all
PrunableFailedJobProviderimplementations supported by this command:src/Illuminate/Queue/Failed/DatabaseFailedJobProvider.phpsrc/Illuminate/Queue/Failed/DatabaseUuidFailedJobProvider.phpsrc/Illuminate/Queue/Failed/FileFailedJobProvider.php