Fix: Handle non-string returns from Htmlable::toHtml() in e() helper #57157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds null coalescing to maintain backward compatibility when
Htmlable::toHtml() returns non-string values.
**Breaking Change Context:**
The addition of explicit `: string` return type creates a BC break because
Htmlable::toHtml() only has PHPDoc type hints, not runtime enforcement.
IMHO it should probably be reverted, this commit provides at least some backward compatibility.
**Example of previously valid code that now breaks:**
```php
class CustomHtmlable implements Htmlable
{
public function toHtml()
{
// Valid before: PHPDoc says @return string but no runtime enforcement
return $this->hasContent() ? $this->content : null;
}
}
// This worked before but now causes TypeError
echo e(new CustomHtmlable());
tegos
pushed a commit
to tegos/laravel-framework
that referenced
this pull request
Sep 28, 2025
…aravel#57157) This adds null coalescing to maintain backward compatibility when Htmlable::toHtml() returns non-string values. **Breaking Change Context:** The addition of explicit `: string` return type creates a BC break because Htmlable::toHtml() only has PHPDoc type hints, not runtime enforcement. IMHO it should probably be reverted, this commit provides at least some backward compatibility. **Example of previously valid code that now breaks:** ```php class CustomHtmlable implements Htmlable { public function toHtml() { // Valid before: PHPDoc says @return string but no runtime enforcement return $this->hasContent() ? $this->content : null; } } // This worked before but now causes TypeError echo e(new CustomHtmlable());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds null coalescing to maintain backward compatibility when Htmlable::toHtml() returns non-string values.
Breaking Change Context:
The addition of explicit
: stringreturn type creates a BC break because Htmlable::toHtml() only has PHPDoc type hints, not runtime enforcement.IMHO it should probably be reverted, this commit provides at least some backward compatibility.
Example of previously valid code that now breaks: