Skip to content

feat: added detailed about for queue failover driver #57582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 1 commit into from
Oct 30, 2025
Merged

feat: added detailed about for queue failover driver #57582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Illuminate/Foundation/Console/AboutCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,21 @@ protected function gatherApplicationInformation()
},
'Mail' => config('mail.default'),
'Octane' => config('octane.server'),
'Queue' => config('queue.default'),
'Queue' => function ($json) {
$queueConnection = config('queue.default');

if (config('queue.connections.'.$queueConnection.'.driver') === 'failover') {
$secondary = new Collection(config('queue.connections.'.$queueConnection.'.connections'));

return value(static::format(
value: $queueConnection,
console: fn ($value) => '<fg=yellow;options=bold>'.$value.'</> <fg=gray;options=bold>/</> '.$secondary->implode(', '),
json: fn () => $secondary->all(),
), $json);
}

return $queueConnection;
},
Comment on lines +226 to +240
Copy link
Contributor

@shaedrich shaedrich Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, we could extract this logic into a separate method, so that we can reuse it here as well as for the 'Cache' and the 'Logs' case above.

Copy link
Contributor Author

@chinmaypurav chinmaypurav Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that.

Copy link
Contributor Author

@chinmaypurav chinmaypurav Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we let this go for now and we can consider the whole refactor later, because I intend to make a similar PR for mail as well, the internal key structure is not very symetrical and we will need to pass each wrapper key in that.

This will be for logging, cache, queue (current PR) and mail (future PR).

'Scout' => config('scout.driver'),
'Session' => config('session.driver'),
]));
Expand Down