[12.x] Remove unused closure parameters in DatabaseServiceProvider #57644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused
$appparameters from closures that don't use the application container instance.Changes:
db.transactionssingleton: Remove unused$appparameterConcurrencyErrorDetectorContractsingleton: Remove unused$appparameterLostConnectionDetectorContractsingleton: Remove unused$appparameterBenefits:
Rationale:
These closures only instantiate classes without dependencies (
DatabaseTransactionsManager,ConcurrencyErrorDetector,LostConnectionDetector), so they don't need access to the application container.Testing:
Before:
After: