[12.x] Allow Factory connection method to accept null

[jackbayliss]

In some of my factories I pass in the connection such as:

Product::connection('replica-1')->factory()->create(); 

However, the definition references another factory ie:

    public function definition(): array
    {
        return [
            'user_id'  => User::factory(),
        ];
    }

I want to pass the connection through ie User::factory()->connection($this->connection)

but, the connection can be null - as i'm not setting a connection in every test so I end up having to do:

// Before
    public function definition(): array
    {
        return [
             'user_id'  => $this->connection ? User::factory()->connection($this->connection) : User::factory()
        ];
    }

// After
    public function definition(): array
    {
        return [
             'user_id'  => User::factory()->connection($this->connection);
        ];
    }

This is just a bit of DX, as the connection property can be null.

Thanks

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.