[12.x] Add missing docblock param in FailedOver event docblocks #58123
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackbayliss
changed the title
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
commented
Dec 15, 2025
Comment on lines
13
to
18
| * @param \Closure|string|object $command The job instance. | ||
| * @param Throwable $exception The exception that was thrown. | ||
| */ | ||
| public function __construct( | ||
| public ?string $connectionName, | ||
| public mixed $command, |
Contributor
Author
There was a problem hiding this comment.
The docblock was set to $job rather than $command (what it is currently), but feels like it really should be $job - dunno if its a BC, so up to you on that 🫡 - I can adjust if you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was poking about thinking about a new Failover class for something👀 but noticed these.
Just for clarity, tooling, and static analysis / aligns with everywhere else.