Skip to content

Update Command::withProgressBar phpdoc to account for arrow functions and non-void return types #58766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
billypoke wants to merge 4 commits into
base: 12.x
Choose a base branch
from
Draft

Update Command::withProgressBar phpdoc to account for arrow functions and non-void return types #58766

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c6f9ad
Allow `mixed` return type on `withProgressBar` $callback param
billypoke Feb 11, 2026
57718de
wrap return type
billypoke Feb 11, 2026
0aed2f5
workaround for phpstan union types
billypoke Feb 12, 2026
9cf712d
Add new template types for callback return and overall function return
billypoke Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Illuminate/Console/Concerns/InteractsWithIO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,12 @@ public function table($headers, $rows, $tableStyle = 'default', array $columnSty
*
* @template TKey of array-key
* @template TValue
* @template TIterable of iterable<TKey, TValue>
* @template TReturnType
*
* @param iterable<TKey, TValue>|int $totalSteps
* @param \Closure(\Symfony\Component\Console\Helper\ProgressBar|TValue, \Symfony\Component\Console\Helper\ProgressBar|null, TKey|null): void $callback
* @return mixed|void
* @param TIterable|int $totalSteps
* @param \Closure(\Symfony\Component\Console\Helper\ProgressBar): TReturnType|\Closure(TValue, \Symfony\Component\Console\Helper\ProgressBar, TKey): TReturnType $callback
* @return ($totalSteps is iterable ? TIterable : void)
*/
public function withProgressBar($totalSteps, Closure $callback)
{
Expand Down