[13.x] Feat (Added): Provision to specify default connection for migration #58944
Closed
aagjalpankaj wants to merge 1 commit intolaravel:13.xfrom
Closed
[13.x] Feat (Added): Provision to specify default connection for migration #58944aagjalpankaj wants to merge 1 commit intolaravel:13.xfrom
aagjalpankaj wants to merge 1 commit intolaravel:13.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
47f6cc6 to
f66b8f3
Compare
f66b8f3 to
84d2e98
Compare
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes discussion #54035
What it does?
Allows provision to specify default connection for migrations (by specifying config value
database.migrations.connection).So the priority for connection will be as below (Highest to Lowest):
$connectionproperty orSchema::connection()in the migration file (Existing)--database=<connection>when runningphp artisan migrate(Existing)database.migrations.connectionconfiguration value (new feature)database.defaultconfiguration value (Existing)Why?
I have seen Laravel applications following separate connection for application (DML permissions) and migration (DDL permissions) due to some architectural decisions.
Schema::connection('connection')->while writing each migration or runningartisan migrate --database=<connection>is not always handy.migrationstable is created using default application connection.artisan migratecommand without allowing--databaseoption.This feature provides a "set once, use everywhere" solution through configuration, eliminating manual overhead while maintaining full backward compatibility.