Add RegistersRouteFiles trait to ServiceProvider#59152
Draft
garanaibrahim7 wants to merge 2 commits intolaravel:12.xfrom
Draft
Add RegistersRouteFiles trait to ServiceProvider#59152garanaibrahim7 wants to merge 2 commits intolaravel:12.xfrom
garanaibrahim7 wants to merge 2 commits intolaravel:12.xfrom
Conversation
Contributor
|
So instead of calling: $router->middleware(['api', 'auth:sanctum'])
->prefix('/api')
->as('api.')
->group($app->basePath('routes/api.php'));Your proposal is this would be more "fluent" or straightforward? $router->registerRouteFiles('api', [
'middleware' => ['api', 'auth:sanctum'],
'prefix' => '/api',
'as' => 'api.',
]);Are there any other benefits that would counter the loss of IDE autocompletion, for example? Mind that <?php
use Illuminate\Foundation\Application;
use Illuminate\Foundation\Configuration\Exceptions;
use Illuminate\Foundation\Configuration\Middleware;
use Illuminate\Routing\Router;
return Application::configure(basePath: dirname(__DIR__))
->withRouting(function (Application $app, Router $router) {
$router->middleware(['api', 'auth:sanctum'])
->prefix('/api')
->as('api.')
->group($app->basePath('routes/api.php'));
$router->middleware('web')
->group($app->basePath('routes/web.php'));
})
->withCommands([dirname(__DIR__) . '/routes/console.php'])
->withMiddleware(function (Middleware $middleware): void {
//
})
->withExceptions(function (Exceptions $exceptions): void {
//
})->create(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a
RegistersRouteFilestrait toServiceProviderthat providesa fluent, cache-compatible API for loading route files without manual
requirecalls or repetitiveRoute::group()boilerplate.Usage
$this->registerRouteFiles('api');
$this->registerRouteFiles(['web', 'api', 'admin']);
$this->registerRouteFiles('api/v2', [
'middleware' => ['api', 'auth:sanctum'],
'prefix' => 'api/v2',
]);
Why
require— fully compatible withphp artisan route:cache