Improvements for asserting HTML in text#59161
Open
jasonmccreary wants to merge 2 commits intolaravel:13.xfrom
Open
Improvements for asserting HTML in text#59161jasonmccreary wants to merge 2 commits intolaravel:13.xfrom
jasonmccreary wants to merge 2 commits intolaravel:13.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves some papercuts with
assertSeeTextand similar assertions:Failed asserting thatprefix added to the assertion failures.A few notes. First, to minimize the footprint, I created a single constraint class (
SeeInHtml) with multiple parameter flags, rather than multiple, very similar constraint classes (e.g.SeeInHtml,NotSeeInHtml,SeeInHtmlInOrder).Second, there were some recent changes to these assertions in 12.x which may create a conflict when merging with 13.x.
Finally, while not a breaking change in code per se, I targeted 13.x as it is a change in the behavior/output. Although the developer should not see this since both the expected and actual values are normalized. Meaning if a developer was indeed checking for exact whitespace within their HTML text, their assertion should still pass.