[13.x] Add schedule resume and pause events#59172
Open
jackbayliss wants to merge 1 commit intolaravel:13.xfrom
Open
[13.x] Add schedule resume and pause events#59172jackbayliss wants to merge 1 commit intolaravel:13.xfrom
jackbayliss wants to merge 1 commit intolaravel:13.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last PR went surprisingly well, so because we can now pause and resume the schedule... matching events are nice so we can ping off Slack notifications etc or do whatever logic we want when someone does it. This mirrors the queue pause / resume events.. we love events.
I was going to
this->laravel->makelike theScheduleFinishCommandbut just injected it.. felt cleaner.Two very boring tests to prevent regression.
Open to renaming or any feedback.
Thanks!