Skip to content

Websockets #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2018
Merged

Websockets #1000

merged 2 commits into from
Dec 11, 2018

Conversation

svpernova09
Copy link
Contributor

No description provided.

@svpernova09 svpernova09 merged commit 042547e into master Dec 11, 2018
@svpernova09 svpernova09 deleted the websockets branch December 11, 2018 01:32
@svpernova09 svpernova09 restored the websockets branch December 11, 2018 01:38
@svpernova09 svpernova09 deleted the websockets branch December 11, 2018 01:40
@lcharette
Copy link

FYI, adding the web socket domain create a breaking change. When single domain is defined in Homestead.yaml, it used to be reachable using the VM IP address. Adding the socket-wrench.test make it so browsing to the VM IP address errors out with the "No Input File" message.

@svpernova09
Copy link
Contributor Author

FYI, adding the web socket domain create a breaking change

Yep! the next version will be a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svpernova09 @lcharette