[3.x] Copy Blade files on installation#1118
Merged
taylorotwell merged 1 commit intomasterfrom Aug 15, 2022
Merged
Conversation
f8eb142 to
35945af
Compare
Member
|
@jessarcher thanks - will we need any docs changes here? |
Member
Author
|
@taylorotwell indeed! I have created a draft PR at laravel/jetstream-docs#70 to add docs for |
Closed
|
No offense but the prefix for jetstream components was very handy since it is package specific. Whitout prefix, given that they are very generically named, just copying them in the |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Jetstream so that it copies the Livewire components on installation to make it more like the Vue stack, and more like Breeze.
I've placed them in
resources/views/componentsinstead ofresources/views/vendor/jetstream/componentswhere they are currently published, to give the user a better sense of ownership over the components, and to leverage Laravel's anonymous components. This also means thejet-prefix is no longer used, but I think that's a good thing.Finally, I've also made it copy the email views on installation for both stacks so there are now no resources that aren't copied on installation. I've placed them in
resources/views/emailsrather thanresources/views/vendor/jetstream/mailfor the reasons previously mentioned. I've usedemailsinstead ofmailto match the Laravel docs (here and here).I've targetted
masterbecause I believe it is a breaking change to remove the ability for existing Jetstream users to publish the views.