Fixes publishing jetstream-inertia-auth-pages, that was referencing an old stub path#1210
Merged
taylorotwell merged 1 commit intolaravel:2.xfrom Jan 4, 2023
juse-less:bugfix/inertia-vue-component-stub-path
Merged
Fixes publishing jetstream-inertia-auth-pages, that was referencing an old stub path#1210taylorotwell merged 1 commit intolaravel:2.xfrom juse-less:bugfix/inertia-vue-component-stub-path
taylorotwell merged 1 commit intolaravel:2.xfrom
juse-less:bugfix/inertia-vue-component-stub-path
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When publishing Inertia assets (
artisan vendor:publish --provider=Laravel\\Jetstream\\JetstreamServiceProvider,artisan vendor:publish --tag=jetstream-inertia-auth-pages, etc), you're presented with an error that some of the paths related tojetstream-inertia-auth-pagescan't be located.This is because Jetstream v2.11.0 (more specifically PR #1110) moved the Vue component stubs from
stubs/inertia/resources/js/Jetstreamtostubs/inertia/resources/js/Components.I adjusted those paths in the service provider that registers the publishables.
I also removed the publishing of
stubs/inertia/resources/js/Components/ValidationErrors.vueentirely, as that component was removed in v2.11.1 (PR #1123).The Jetstream installation command was already publishing everything correctly.
I've tested against the project where I accidentally noticed this (fresh Laravel repo), and my changes made both publish commands mentioned above work.
Screenshot of the error in the terminal