[1.x] Fix composer memory limit crashes#412
Merged
taylorotwell merged 2 commits intolaravel:1.xfrom Oct 29, 2020
claudiodekker:fix-composer-crash
Merged
[1.x] Fix composer memory limit crashes#412taylorotwell merged 2 commits intolaravel:1.xfrom claudiodekker:fix-composer-crash
taylorotwell merged 2 commits intolaravel:1.xfrom
claudiodekker:fix-composer-crash
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where Composer (1.x?) runs out of memory while Jetstream installs stack-dependent packages.
I personally ran into this issue a few weeks ago, but after seeing others on the Inertia.js discord run into it today, I decided to PR it.
Basically, what they'll see is the following:
By setting the
COMPOSER_MEMORY_LIMIT=-1environment variable, we temporarily unrestrict composer's memory limit to allow for the install to succeed on the first try.