Clears any validation error message before re-displaying confirmation#487
Merged
taylorotwell merged 1 commit intolaravel:1.xfrom Nov 25, 2020
Merged
Clears any validation error message before re-displaying confirmation#487taylorotwell merged 1 commit intolaravel:1.xfrom
taylorotwell merged 1 commit intolaravel:1.xfrom
Conversation
It's a small change, but it should be OK. 🤓 Previously, there was a **very minor** issue if the following steps were followed: - log in - navigate to profile - delete account - enter incorrect password - note the validation error message - close confirmation window via ESC or Nevermind - delete account...again The issue: the validation error message is still displayed. I've simply added `$this->resetErrorBag();` to make sure that validation errors are cleared each time the user attempts to delete their account. Please let me know if there are any problems/questions. Thx...! 🤓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a small change, but it should be OK. 🤓
Previously, there was a very minor issue if the following steps were followed:
The issue: the validation error message is still displayed.
I've simply added
$this->resetErrorBag();to make sure that validation errors are cleared each time the user attempts to delete their account.Please let me know if there are any problems/questions. Thx...! 🤓