[2.x] Allow custom classes on the dropdown class#661
Merged
taylorotwell merged 6 commits intolaravel:2.xfrom Feb 5, 2021
natecorkish:patch-1
Merged
[2.x] Allow custom classes on the dropdown class#661taylorotwell merged 6 commits intolaravel:2.xfrom natecorkish:patch-1
taylorotwell merged 6 commits intolaravel:2.xfrom
natecorkish:patch-1
Conversation
Use case: a person may want to show the dropdown on the left on mobile, but to the right on the web. Currently they don't have an option for that. So they could do: `left-0 md:right-0`
|
that way, if not passed the dropdownClasses by parameter will give variable error |
driesvints
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To keep code duplication to a minimum, people re-use components from jet stream, for example the dropdown, currently the dropdown only has a pre-set alignment, a person may want to show the dropdown on the left-side on mobile phones, but to the right on a web browser. Currently they don't have an option for that. So; with this PR they could do the following: