[2.x] Fix overflow hidden issue with overlaping elements inside form section#668
Merged
taylorotwell merged 2 commits intolaravel:2.xfrom Feb 9, 2021
Merged
Conversation
driesvints
changed the title
Member
|
Doesn't make sense to me to only have the top corners rounded when there are actions? |
Member
|
An type="date" input looks fine to me on Chrome...
|
Contributor
Author
|
But for example custom datepicker has the behavior like on my screenshot. My pr remove the overflow-hidden from paren div and ads rounded corners at top left, top right and at the bottom of the form section. Even if there is no actions, rounded corners will be present at the bottom. |
Member
|
Got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I found issue with form section when it has small height and we have bigger elements inside it that overextends
the height of the form section. For example datapicker, dropdown etc. I attached screen below to show the issue.
My pull request fix that issue by slightly change the classes in form section components.
I have modified inertia and livewire component.