Test team features only when active#698
Merged
taylorotwell merged 3 commits intolaravel:2.xfrom Mar 3, 2021
Merged
Conversation
Added a condition to create the actingAs user with team features only when teams are enabled.
Added a condition to create the actingAs user with team features only when teams are enabled, this time for Inertia.
Fixed an issue in the formatting spotted by StyleCI
Contributor
Author
|
@driesvints I see you've been instructing people to just delete the tests they aren't using. To be clear, in this case, I am using these tests, just not with the teams feature(s). Also, for future reference, I see tests/P7.3 - L^8.0 is failing. Is this something I can resolve and if so, any pointers on how? |
Member
|
@tedsecretsource tests are failing because of new GH Actions ubuntu builds. I'll fix them today. |
keljtanoski
added a commit
to keljtanoski/jetstream
that referenced
this pull request
Mar 5, 2021
Test team features only when active (laravel#698)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a condition in the Inertia and Livewire tests to only test team features if Teams have been enabled. At present, some tests are failing because they expect teams to always be enabled.
This is my first, proper, PR for Laravel, so, if there is a better way to address this issue (like making
withPersonalTeam()return null if the teams feature isn't enabled), I'm more than happy to head down that path, just point me in that direction!