[2.x] Support both Alpine V2 and V3#813
Merged
taylorotwell merged 1 commit intolaravel:2.xfrom Jun 24, 2021
Merged
Conversation
Member
|
Thanks @calebporzio. We can probably move to v3 entirely in Jetstream v3 (master branch). Once this PR is merged and merged into master we can do the changes for v3 there. |
Contributor
Author
|
Ok, will PR - thanks @driesvints! |
Contributor
Author
|
Looking at master: looks like I don't have to. |
Member
|
@calebporzio I just merged 2.x into master 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem scenario:
@click.outsidewhich is new in V3x-transition...which is new in V3Solution:
.awayinstead of.outside- they are aliases and both exist in V2 and V3x-show.transition...as well as the newx-transition...helpers. Each will work on their respective versions without causing breakages.After this PR, all Jetsream stubs will be upgrade safe and support any version of Alpine a project is using.