Use Alpine's @click.prevent for log out#989
Merged
taylorotwell merged 1 commit intolaravel:2.xfrom Mar 2, 2022
kastsecho:alpine-logout
Merged
Use Alpine's @click.prevent for log out#989taylorotwell merged 1 commit intolaravel:2.xfrom kastsecho:alpine-logout
taylorotwell merged 1 commit intolaravel:2.xfrom
kastsecho:alpine-logout
Conversation
Member
|
Clean - thanks. |
|
This would also be great for the |
Contributor
Author
|
@mikemand Good catch. I hadn't noticed that there was another component was using the same approach as this. I could make a PR later today for it to be consistent with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will switch the
Log Outlinks in the Livewire navigation menu component from vanilla JS to Alpine's@click.preventdirective for a cleaner approach with the same result. Also, it should eliminate squawking from IDE's about using theeventcontext when preventing the default action on clicking the links.