-
Notifications
You must be signed in to change notification settings - Fork 2
Remove pnpm-only public-hoist-pattern from kit .npmrc (npm warns on every run) #68
Copy link
Copy link
Open
Description
Current generated .npmrc for Inertia blank base includes:
public-hoist-pattern[]=@inertiajs/core
When users run npm in generated kits, npm prints a warning each time because public-hoist-pattern is not an npm config key.
Repro:
- Create a Laravel app using an Inertia starter kit
- Open the generated project root
- Run
npm install(or anynpmcommand) - Observe warning about unknown project config
public-hoist-pattern
Why this matters:
- noisy DX for default npm users
- npm warns unsupported custom keys may stop working in a future major
Source in Maestro:
- Introduced in PR Inertia globals #20 (
kits/Inertia/Blank/Base/.npmrc)
Suggested fix:
- Remove
public-hoist-pattern[]=@inertiajs/corefrom Maestro kit.npmrc
Related:
- laravel/installer issue: npm warn Unknown project config "public-hoist-pattern". installer#488
- npm docs (.npmrc, unsupported custom keys): https://docs.npmjs.com/cli/v11/configuring-npm/npmrc
- pnpm docs (
publicHoistPattern): https://pnpm.io/settings
If this direction looks good, I can open a PR against Maestro with the minimal change.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.