Handle Vite 5 types changes#254
Closed
bluwy wants to merge 2 commits intolaravel:mainfrom
bluwy:vite-5-types
Closed
Handle Vite 5 types changes#254bluwy wants to merge 2 commits intolaravel:mainfrom bluwy:vite-5-types
bluwy wants to merge 2 commits intolaravel:mainfrom
bluwy:vite-5-types
Conversation
Closed
Member
|
Really appreciate you sliding into our Laravel plugin, @bluwy, to help get us ready for Vite 5 ❤️ I've take the changes here and added them to our single PR to upgrade to Vite 5. I'll close this one off, but thank you so much. We are also gonna drop Vite 4 support, so it should make things a little smoother with type changes. |
Author
|
No problem! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite 5 removes the
https: booleantype and as it doesn't have much use by default. A plugin or manual configuration is always needed forhttpsto actually work (e.g. certs). (vitejs/vite#14681)This PR updates the types breaking change caused by it. It uses
@ts-ignoreso it works on both Vite 4 and 5. Theas anyis also needed so theconfighook doesn't error by TS due to incorrect type returned by the function.Extra notes unrelated to PR
It seems like before (Vite 4), users could do
vite --httpsorhttps: trueinvite.config.jsto get the right certs generate bylaravel-vite-plugin. In Vite 5, this isn't possible anymore except ifhttps: {}invite.config.js. Though it isn't quite exactly documented in the laravel docs.Just want to note this in case you want to handle this differently in the future. For example, the
detectTlscould be used to enablehttpsinternally. Right now it doesn't due to the existing logic here:vite-plugin/src/index.ts
Lines 163 to 166 in 7abca67