Fix: Str::lower() expects string, Stringable given

[Aluisio-Pires]

At the start of every project, phpstan complains that $this->string('email') is not a string but a Illuminate\Support\Stringable.
This PR fixes that issue.

[firebed]

You can directly call $this->input('email')

[Aluisio-Pires]

$this->input('email') returns a mixed type. To ensure string type we need to use $this->string('email')->value()

[Aluisio-Pires]

[firebed]

Oh I see, you're right. However, I am still convinced we should not create a Stringable object just to get the string value of the email. Maybe casting to string is a better way. What do you think? Is phpstan still complaining?

(string)$this->input('email')

[Aluisio-Pires]

Since the type of $this->input('email') is mixed, we can’t cast it directly to a string.

[firebed]

Stringable under the hood does casting mixed type into string and to me $this->string('email')->value() feels like a hack into tricking phpstan because it accomplises the same result with extra steps just to make phpstan happy 😕

[Plytas]

I think a proper fix here would be to PR a change to the framework Str methods to accept an instance of Stringable.

[Aluisio-Pires]

Stringable under the hood does casting mixed type into string and to me $this->string('email')->value() feels like a hack into tricking phpstan because it accomplises the same result with extra steps just to make phpstan happy 😕

You’re partly correct: the returned Stringable does convert the mixed value to string under the hood, but it remains a Stringable instance, not a native string. To extract a pure string, you must call value(), which returns the object’s underlying string.
You can use this video of Nuno Maduro as reference.

[Aluisio-Pires]

I think a proper fix here would be to PR a change to the framework Str methods to accept an instance of Stringable.

This doesn’t only occur in Str methods but in any methods that work with the string type. Using ->value() is a best practice to convert to PHP’s native string type in these cases.
Here are some examples of PHP functions that take a string as a parameter: strlen(), substr(), strpos(), trim(), str_replace(), explode(), preg_match(), json_encode()

[Plytas]

Aware of that. But as a framework it should provide convenience wherever possible.

[firebed]

You can tell that even the author's original intention wasn't to create a stringable object, because he could chain the ->lower() method instead of wrapping the entire thing into Str::lower. In any case; your pr makes sense, but the underlying issue remains. Honestly I would just ignore this error in phpstan.