fix #702 : fixed bug when writing metadata using HDF format #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdementen
requested changes
Feb 4, 2019
|
A test already exists: see test_h5_io() in test_session.py |
|
why didn't it pick up the failure then? |
|
Maybe linked to the version used of pytables ? |
|
I think it's more likely the version of pandas. But the first thing to do in any case when fixing a bug is reproduce it. Otherwise you don't know whether you actually fixed it or not. If that's indeed related to a lib version, we don't need to add any extra test but at least we could document it and possibly blacklist that particular version. |
|
I guess the changelog message needs to be somehow changed. |
alixdamman
force-pushed
the
702_fix_metadata
branch
from
b3122d8 to
8a0a046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.