monster PR #779
Merged
monster PR #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many tests are failing with python 2.7 😢 ... I'll fix that ASAP, but since this shouldn't change the API, you can start reviewing this monster if you have time. |
|
Oh, and I still must tackle #711. Should be easy now that this PR is done. |
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
This was referenced Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
alixdamman
reviewed
Jun 24, 2019
|
LGTM. Push when you feel ready. |
|
@alixdamman I added a few missing tests and (hopefully) resolved the remaining issues you pointed. Do you think the last commit (about LArray.keys, values & items) is good enough (until we fix the issue properly in #447)? |
|
The last commit is good enough for me. |
it computes unique values across multiple iterables
…e key (the key wasn't used anywhere)
…PI function: wrap_elementwise_array_func
…deprecated LArray.as_table() (merged in LArray.dump()) and fixed 65535 bug
* generalized it to more than one dimension (closes #56) - works for both stack([(ndkey, value), ...], axis=axes) and stack({ndkey: value}, several_axes) - deprecated axis argument in favor of axes * changed the exception when using **kwargs without an axis on Python < 3.6 to a warning * allowed using a dict without axis (closes #581, closes #755) This will produces a warning on Python < 3.7 * added support for res_axes
we should use raise(match=) instead of raise(message=)
…ough (no longer used)
(it does not exist any more)
(in comments, error message and docstrings)
…e click away anyway) I kept them for improvements because in that case the examples for that specific change are usually buried in a lot of other code.
this also slightly simplify _key_to_igroups
reordered by perceived importance, add a few links, remove broken links, etc.
gdementen
force-pushed
the
monster_branch
branch
from
551c211 to
2f353a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after a few marathon rebases, here it is finally. Sorry it took so long and sorry for the monstruous size.
As reviewing the implementation is much less important than reviewing the API (mostly method names and argument names), you could concentrate yourself on the "implemented XXX" commits.
Also, I don't know whether wrap_elementwise_array_func, zip_array_values and zip_array_items should be mentioned in the API & changelog.
Those are pretty advanced functions and I don't expect any of our users to use them by themselves but we will add them to their code,
so it might make the case for adding them to the API/changelog in case they wonder what they are.
Currently, wrap_elementwise_array_func is mentionened but zip* are not.