Correction to the Hungarian language support in varioref.sty

[tibortomacs]

Dear Maintainer,

My name is Tibor Tómács, and I am the maintainer of the hungarian-babel package.
I would like to draw your attention to the fact that the current Hungarian language implementation in varioref.sty is not fully correct.

Below, I am providing a corrected version that addresses the identified issues.
I would appreciate it if you could review this correction and consider incorporating it into the package.

\def\vref@hu@strings{%
  \def\reftextafter {a k\"ovetkez\H{o} oldalon}%
  \def\reftextbefore{az el\H{o}z\H{o} oldalon}%
  \def\reftextfaceafter {\reftextvario{a t\'uloldalon}%
                        {a k\"ovetkez\H{o} oldalon}}%
  \def\reftextfacebefore{\reftextvario{a t\'uloldalon}%
                        {az el\H{o}z\H{o} oldalon}}%
  \def\reftextcurrent   {ezen az oldalon}%
  \def\reftextfaraway##1{\az{\pageref{##1}}.~oldalon}%
  \def\reftextpagerange##1##2{\az{\pageref{##1}}--\pageref{##2}.~oldalakon}%
  \def\reftextlabelrange##1##2{\told\ref{##1}+tol{} \ref{##2}-ig}%
  \let\vrefformat\vrefdefaultformat%
  \let\Vrefformat\Vrefdefaultformat%
  \let\fullrefformat\fullrefdefaultformat%
  \let\vrefrangeformat\vrefrangedefaultformat%
}
\DeclareOption{hungarian}{\vref@addto\extrashungarian{\vref@hu@strings}}
\DeclareOption{magyar}   {\vref@addto\extrasmagyar   {\vref@hu@strings}}

Thank you for your time and consideration.

Best regards,
Tibor Tómács
Maintainer of hungarian-babel

[FrankMittelbach]

can't really "verify" can only trust you :-)

[tibortomacs]

Thanks for the correction!
The hungarian and magyar options now look like this:

\DeclareVrefOptions{hungarian,magyar}
  {\def\reftextafter {a k\"ovetkez\H{o} oldalon}%
   \def\reftextbefore{az el\H{o}z\H{o} oldalon}%
   \def\reftextfaceafter {\reftextvario{a t\'uloldalon}%
                         {a k\"ovetkez\H{o} oldalon}}%
   \def\reftextfacebefore{\reftextvario{a t\'uloldalon}%
                         {az el\H{o}z\H{o} oldalon}}%
   \def\reftextcurrent   {ezen az oldalon}%
   \def\reftextfaraway##1{\az{\pageref{##1}}.~oldalon}%
   \def\reftextpagerange##1##2{\az{\pageref{##1}}--\pageref{##2}.~oldalakon}%
   \def\reftextlabelrange##1##2{\told\ref{##1}+tol{} \ref{##2}-ig}%
   \let\vrefformat\vrefdefaultformat
   \let\Vrefformat\Vrefdefaultformat
   \let\fullrefformat\fullrefdefaultformat
   \let\vrefrangeformat\vrefrangedefaultformat
}

In this code, ##1 and ##2 should be corrected to #1 and #2.

[FrankMittelbach]

In this code, ##1 and ##2 should be corrected to #1 and #2.

yes, stupid error on my part. I wondered if I need to add a test file ... but what could go wrong here ... :-(

[tibortomacs]

Here is a test file:

\documentclass{article}

\makeatletter
\AtBeginDocument{
  \def\@@magyar@ccheck#1#2\vfuzz#3{%
    \if\noexpand#1c\relax\else\def\reserved@a{c0}\fi}}
\makeatother
\def\magyarOptions{varioref=unchanged,suggestions=no}

\usepackage[magyar]{babel,varioref}

\begin{document}
\section{Cím}\label{a}
Lásd\vref{a}\\
Lásd\vpageref{a}\\
\vpagerefrange{a}{b}\\
\vrefrange{a}{b}
\newpage
\section{Cím}\label{b}
\end{document}

The expected result

1. Cím

Lásd 1
Lásd ezen az oldalon
az 1–2. oldalakon
1-től 2-ig az 1–2. oldalakon

The \def\magyarOptions{varioref=unchanged,suggestions=no} is needed because magyar.ldf is currently trying to fix this due to the incorrect translation of varioref.sty. This line can be used to disable this fix.

The following is needed in the test file because it fixes a bug in magyar.ldf that is not yet fixed in the version on CTAN.

\makeatletter
\AtBeginDocument{
  \def\@@magyar@ccheck#1#2\vfuzz#3{%
    \if\noexpand#1c\relax\else\def\reserved@a{c0}\fi}}
\makeatother

The long-term goal is to remove the correction code from magyar.ldf by correcting varioref.sty.