-
Notifications
You must be signed in to change notification settings - Fork 9
Adding bower.json #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Looks good. The license is also wrong in We should also change the version 1.0.0 in |
Main file is wrong. It should be 'src/scopedQuerySelectorShim.js' |
Just pushed a new commit that should fix bower.json and package.json. |
@jpdevries Space after |
space added |
@jpdevries Thanks! Can you squash commits? |
@jpdevries Also don't need version field in bower. And package.json version shouldn't be zero. |
After PRs of course. |
@TrySound I'm new to squashing and a bit lost. I tried git rebase -i HEAD~4 and then pick 5112cf4 Adding bower.json
squash b65a991 Correcting bower and package files
squash 222825c Adding space
squash 2940f92 Removing bower version but I don't see the commits being squashed in my local commit history so I'm confused |
@TrySound nevermind, i think i figured the squashing out. sorry for the false alarm. I had Textmate 2 set as my default git editor and it's a bit buggy. After switching it to atom the squashing processes worked ok. |
@jpdevries Thanks! |
So package can be installed via bower Correcting bower and package files Adding space Removing bower version Updating bower ignored bower ignore fix
@jpdevries You didn't clean commit message |
@TrySound i didn't know i needed to clean the commit message. Is that necessary? I'm not sure how without making another commit and then re-squashing. @lazd should probably hold off on merging this PR until #8 has been reviewed because if #8 is merged we may want to make a slight change to |
@jpdevries Sorry for my meticulousness. SourceTree is simpler for exact manipulation. |
Thanks for this @jpdevries, I commented on #8. Like you said, it's probably best to resolve #8 before we merge this. |
this would be cool to have merged. |
@jpdevries Update this PR to work with your changes from #8 and I'll go ahead and do a release! |
🎉 |
So package can be installed via bower. Not sure if the license should be BSD-2 but it seemed like it. Also, assumes a version of "1.0.0"