Skip to content

Adding bower.json #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding bower.json #6

wants to merge 1 commit into from

Conversation

jpdevries
Copy link
Contributor

So package can be installed via bower. Not sure if the license should be BSD-2 but it seemed like it. Also, assumes a version of "1.0.0"

@lazd
Copy link
Owner

lazd commented Jun 26, 2015

Looks good. The license is also wrong in package.json, if you want to correct it there, then we'll be set.

We should also change the version 1.0.0 in package.json, upgrade dependencies, and use ^ instead of ~ for version ranges.

@TrySound
Copy link

Main file is wrong. It should be 'src/scopedQuerySelectorShim.js'
Also add it to package.json

@TrySound
Copy link

@jpdevries
Copy link
Contributor Author

Just pushed a new commit that should fix bower.json and package.json.

@TrySound
Copy link

@jpdevries Space after "main":, please.

@jpdevries
Copy link
Contributor Author

space added

@TrySound
Copy link

@jpdevries Thanks! Can you squash commits?

@TrySound
Copy link

@jpdevries Also don't need version field in bower. And package.json version shouldn't be zero.
@lazd Which version do you want? Maybe it's time for 1.0.0?

@TrySound
Copy link

After PRs of course.

@jpdevries
Copy link
Contributor Author

@TrySound I'm new to squashing and a bit lost. I tried

git rebase -i HEAD~4

and then

pick 5112cf4 Adding bower.json
squash b65a991 Correcting bower and package files
squash 222825c Adding space
squash 2940f92 Removing bower version

but I don't see the commits being squashed in my local commit history so I'm confused

@jpdevries
Copy link
Contributor Author

@TrySound nevermind, i think i figured the squashing out. sorry for the false alarm. I had Textmate 2 set as my default git editor and it's a bit buggy. After switching it to atom the squashing processes worked ok.

@TrySound
Copy link

@jpdevries Thanks!

So package can be installed via bower

Correcting bower and package files

Adding space

Removing bower version

Updating bower ignored

bower ignore fix
@TrySound
Copy link

@jpdevries You didn't clean commit message

@jpdevries
Copy link
Contributor Author

@TrySound i didn't know i needed to clean the commit message. Is that necessary? I'm not sure how without making another commit and then re-squashing.

@lazd should probably hold off on merging this PR until #8 has been reviewed because if #8 is merged we may want to make a slight change to bower.json so that only the new dist directory is fetched

@TrySound
Copy link

@jpdevries Sorry for my meticulousness.
I ussually do this for the last commit:
git reset HEAD~1
git add *
git commit -m ...
git push --force

SourceTree is simpler for exact manipulation.

@lazd
Copy link
Owner

lazd commented Jul 6, 2015

Thanks for this @jpdevries, I commented on #8. Like you said, it's probably best to resolve #8 before we merge this.

@RIAEvangelist
Copy link

this would be cool to have merged.

@jpdevries
Copy link
Contributor Author

@lazd let me know if there's anything else I can do to get #8 merged

@lazd
Copy link
Owner

lazd commented Mar 3, 2016

@jpdevries Update this PR to work with your changes from #8 and I'll go ahead and do a release!

@jpdevries
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants