Skip to content

retain copyright notice #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jpdevries
Copy link
Contributor

Correct me if I'm wrong but it seems like scopedQuerySelectorShim.js disobeys it's own LICENSE. The README says to simply include the scopedQuerySelectorShim.js file, but it that is all you do you disobey the LICENSE.

@lazd
Copy link
Owner

lazd commented Jun 26, 2015

Yeah, scopedQuerySelectorShim.js could benefit from a license header.

I'd expect something like this, however, that calls out what license is being used:

/* scopeQuerySelectorShim.js
 *
 * Copyright (C) 2015 Larry Davis
 * All rights reserved.
 *
 * This software may be modified and distributed under the terms
 * of the BSD license.  See the LICENSE file for details.
 */

@jpdevries
Copy link
Contributor Author

What do you think about making use of the Grunt workflow to build an unminified and minified version of the source file with said header included? If that sounds like something you might be interested in I'd be happy to submit a PR

@lazd
Copy link
Owner

lazd commented Jun 27, 2015

Sounds good, as long as the version you get when you install with Bower still has the header!

@jpdevries
Copy link
Contributor Author

ya, i think we could manage that using exportOverrides. I'll see what I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants