Skip to content

Add Get Diagnostics service for chargers that support it #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Jul 29, 2021
Merged

Add Get Diagnostics service for chargers that support it #109

merged 50 commits into from
Jul 29, 2021

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Jul 28, 2021

No description provided.

drc38 and others added 30 commits July 25, 2021 12:54
@drc38
ocpp: set unavailable state on charger disconnect
aa3972f
@drc38
Merge pull request #15 from drc38/bug-fix-location
037da54 
Bug fix location
@drc38
Merge pull request #16 from drc38/tests
8c6a8bb 
Tests
@drc38
Merge pull request #17 from drc38/available
93ffe57 
ocpp: set unavailable state on charger disconnect
@drc38
ocpp: fix cp_id reference
fcb01a9
@drc38
ocpp: fix cp_id reference
7d4aa01
@drc38
Merge branch 'available' of https://github.com/drc38/ocpp into available
3b3bf4a
@drc38
tests: start charger first
f9d6fbc
@drc38
tests: handle websocket close exception
19850fe
@drc38
tests: update assert and exc
e547e5f
@drc38
tests: try exc handle again
5b1dff4
@drc38
tests: use gather to return exc
e4b7a97
@drc38
tests: revert to 1 gather
ee1eadb
@drc38
tests: change status notify to increase code coverage
ca946d8
@drc38
tests: extra status notification
9b63c4b
@drc38
tests: try reconnecting
5234f8d
@drc38
and again
dcf399a
@drc38
ocpp: improve reconnection
646609e
@drc38
tests: add remote stop transaction
617e90d
@drc38
ocpp: set status on reconnect
3fddd9c
@drc38
tests: increase fail under to 90%
6f37ab8
@drc38
test: add extra sampled values
956ebaf
@drc38
Merge branch 'main' into available
be0f6e7
@drc38
tests: fix assert error
ca79ed1
@drc38
Merge branch 'available' of https://github.com/drc38/ocpp into available
bca2e8d
@drc38
Merge pull request #18 from drc38/available
8357855 
ocpp: fix cp_id reference
@drc38
tests: test service calls
775a1fe
@drc38
tests: correct switch domain
faef9f7
@drc38
tests: fix enum refs
c01f8cb
@drc38
tests: fix enums refs
b44d103
drc38 and others added 19 commits July 26, 2021 18:32
@drc38
tests: limit services
17b7e6a
@drc38
tests: change dict value to str
78b2afa
@drc38
Merge pull request #19 from drc38/available
a0504ac 
tests: test service calls
@drc38
ocpp: add get_diagnostics service
0598a90
@drc38
Merge remote-tracking branch 'upstream/main' into get_diagnostics
4e4a6ce
@drc38
Merge pull request #20 from drc38/get_diagnostics
b135a4a 
ocpp: add get_diagnostics service
@drc38
ocpp: add service warnings if charger unavailable
8de9d12
@drc38
ocpp: add sleep to allow time to process disconnect
0f89b6b
@drc38
tests: shorten timeouts
1ed8701
@drc38
ocpp: fix services.yaml
99328fe
@drc38
Merge pull request #21 from drc38/get_diagnostics
9e16dbd 
ocpp: add service warnings if charger unavailable
@drc38
Merge branch 'lbbrhzn:main' into main
4c62b3f
@drc38
ocpp: handle optional key lists in get_configuration
f61d4f3
@drc38
ocpp: tidy get_configuration calls
8dfbfff
@drc38
Merge pull request #22 from drc38/get_diagnostics
8701787 
ocpp: handle optional key lists in get_configuration
@drc38
ocpp: fix unknown key return
df1f5e1
@drc38
tests: add unknown key test
d96f89d
@drc38
Merge pull request #23 from drc38/get_diagnostics
919c51f 
Get diagnostics
@drc38
Update sensor.py
07cc8bb
@drc38 drc38 added the enhancement New feature or request label Jul 28, 2021
@drc38 drc38 requested a review from lbbrhzn July 28, 2021 05:03
lbbrhzn
lbbrhzn reviewed Jul 28, 2021
View reviewed changes
Copy link
Owner

@lbbrhzn lbbrhzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are a lot of changes, not just for diagnostics. Is that because you've merged on other PRs?

@drc38
Copy link
Collaborator Author

drc38 commented Jul 28, 2021

It includes #106, so assume once #106 is merged then the get diagnostics code will be left. Is there any way to link it to #106 so it shows diffs from there?

@lbbrhzn
Copy link
Owner

lbbrhzn commented Jul 28, 2021

There are some merge conflicts that need to be resolved before this can be merged.

@drc38
Copy link
Collaborator Author

drc38 commented Jul 29, 2021

There are some merge conflicts that need to be resolved before this can be merged.

Cheers, conflicts resolved so it can be merged now.

@lbbrhzn lbbrhzn merged commit a063f3e into lbbrhzn:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbbrhzn lbbrhzn lbbrhzn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drc38 @lbbrhzn