Add number platform using slider (input_number) #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch upstream
Metric class
Supported features
lbbrhzn
approved these changes
Aug 26, 2021
| f"Invalid value for {self.entity_id}: {value} (range {self._minimum} - {self._maximum})" | ||
| ) | ||
|
|
||
| resp = await self.central_system.set_max_charge_rate_amps(self.cp_id, num_value) |
There was a problem hiding this comment.
would be nice to make the service call parameterizable. Maybe hook it up to a Metric, and let the charger subscribe to notifications? I guess the Number entity should also subscribe to the Metric, to make the slider revert to the previous value if the new value cannot be set.
| @property | ||
| def available(self) -> bool: | ||
| """Return if switch is available.""" | ||
| return self.central_system.get_available(self.cp_id) # type: ignore [no-any-return] |
There was a problem hiding this comment.
This will disable the slider when the charge point is not available. From usability point of view it would be nice if you could set the slider value when then charge point is not available. They should then be applied on (re-)connect. I think this should be possible by connecting to a Metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #91, @lbbrhzn feel free to tweak further. Thanks for the help 👍