-
-
Notifications
You must be signed in to change notification settings - Fork 101
Add ZJ Beny to supported devices #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the documentation by adding a new section for the ZJ Beny BCP-A2N-P charging station within the Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/supported-devices.md (1)
124-126
: New Supported Device Section Added SuccessfullyThe new section for the ZJ Beny BCP-A2N-P is a clear and useful addition that aligns with the PR objective. However, static analysis flagged a header style issue on line 124 (MD003): it expected setext style rather than the current ATX style. Consider updating the heading to conform with the project’s markdown guidelines. For example:
-## [ZJ Beny BCP-A2N-P](https://ultipower.com.au/products/zj-beny-home-charging-station-ac-7kw-32a-type-2-ocpp) + [ZJ Beny BCP-A2N-P](https://ultipower.com.au/products/zj-beny-home-charging-station-ac-7kw-32a-type-2-ocpp) + ================================================================Alternatively, if ATX style is intentionally used, you might update the markdownlint configuration to avoid this warning.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
124-124: Heading style
Expected: setext; Actual: atx(MD003, heading-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/supported-devices.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/supported-devices.md
124-124: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 12 12
Lines 2032 2032
=======================================
Hits 1883 1883
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit