Update supported-devices.md #1568
Conversation
Added SyncEV Compact charger as a supported device
WalkthroughThis pull request updates the supported devices documentation by adding a new section for the SyncEV Compact EVCP charger. The section provides detailed information on the charger's specifications as a discontinued 7kw 1PH smart charger with a standard OCPP implementation. It includes setup instructions for SMART mode, outlines the specific measurands (e.g., Voltage, Temperature, Current.Offered, etc.), and offers guidance on creating automations for meter value retrieval and heartbeat adjustments. It also details the required firmware version and procedures for firmware updates via the app. Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ric866
temporarily deployed
to
continuous-integration
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/supported-devices.md (4)
101-104: New Section Introduction & Header Content
– The new section header for the SyncEV Compact EVCP is introduced using an atx heading (##), which appears consistent with other subsections in this document. However, if your style guidelines prefer setext headers for primary sections, please update accordingly.
– In line 102, there is a typographical error: “tolerent” should be corrected to “tolerant”.
– Additionally, note the default credential in line 103 ("The admin panel password is admin"). Although common in documentation, consider adding a note that users should change this default for production use.Diff suggestion for line 102:
-These are a discontinued (but cheap) 7kw 1PH smart charger, with an OCPP implementation that's seemingly quite close to standard, and tolerent. +These are a discontinued (but cheap) 7kw 1PH smart charger, with an OCPP implementation that's seemingly quite close to standard, and tolerant.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
101-101: Heading style
Expected: setext; Actual: atx(MD003, heading-style)
105-106: List Item Formatting & Spelling Correction
– The unordered list items in lines 105–106 are indented with extra spaces (3 spaces observed) whereas the markdown guideline expects no indent for top-level list items.
– In line 105, "retreiving" should be corrected to "retrieving".Diff suggestion for line 105:
- - Force SMART mode, to allow setting charge rates (use action ocpp.set_charge_rate) and retreiving meter values (use action ocpp.trigger_custom_message) + - Force SMART mode, to allow setting charge rates (use action ocpp.set_charge_rate) and retrieving meter values (use action ocpp.trigger_custom_message)Diff suggestion for line 106:
- - Manually specify the Measurands + - Manually specify the Measurands🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
105-105: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
106-106: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
107-112: Nested List Indentation
The sub-list items under "Manually specify the Measurands" (lines 107–112) are indented with 6 spaces, yet markdown style guidelines typically expect a 2-space indent for nested items relative to the parent. Please adjust the indentation to improve readability and conform to the guideline.Diff suggestion (example for line 107; apply similar changes to lines 108–112):
- - Voltage + - Voltage(Adjust the indent so that each sub-item has 2 spaces relative to its parent list item.)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
107-107: Unordered list indentation
Expected: 2; Actual: 6(MD007, ul-indent)
108-108: Unordered list indentation
Expected: 2; Actual: 6(MD007, ul-indent)
109-109: Unordered list indentation
Expected: 2; Actual: 6(MD007, ul-indent)
110-110: Unordered list indentation
Expected: 2; Actual: 6(MD007, ul-indent)
111-111: Unordered list indentation
Expected: 2; Actual: 6(MD007, ul-indent)
112-112: Unordered list indentation
Expected: 2; Actual: 6(MD007, ul-indent)
113-117: List Formatting & Grammar Adjustments in Subsequent Items
– The list items from lines 113 to 117 also have an extra indentation (3 spaces observed); they should start at the same level (no leading spaces) as top-level list items.
– Specifically, in line 114, the phrase “a value different to the one in the chargepoint” should be changed to “a value different from the one in the chargepoint” and “hearbeat” is a typo for “heartbeat.”Diff suggestion for line 114:
- - Optionally create an automation updating the hearbeat interval (you have to set a value different to the one in the chargepoint) when the chargepoint reboots. + - Optionally create an automation updating the heartbeat interval (you have to set a value different from the one in the chargepoint) when the chargepoint reboots.Diff suggestion for line 113 (example adjustment):
- - Create an automation triggering action: ocpp.trigger_custom_message with requested_message set to MeterValues on a schedule of your choice to retrieve the Measurands. + - Create an automation triggering action: ocpp.trigger_custom_message with requested_message set to MeterValues on a schedule of your choice to retrieve the Measurands.(Apply similar un-indentation for lines 115–117.)
🧰 Tools
🪛 LanguageTool
[grammar] ~114-~114: In American English, the usual prepositions after ‘different’ are “from” or “than”.
Context: ...rval (you have to set a value different to the one in the chargepoint) when the ch...(DIFFERENT_TO)
🪛 markdownlint-cli2 (0.17.2)
113-113: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
114-114: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
115-115: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
116-116: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
117-117: Unordered list indentation
Expected: 0; Actual: 3(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/supported-devices.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/supported-devices.md
[grammar] ~114-~114: In American English, the usual prepositions after ‘different’ are “from” or “than”.
Context: ...rval (you have to set a value different to the one in the chargepoint) when the ch...
(DIFFERENT_TO)
🪛 markdownlint-cli2 (0.17.2)
docs/supported-devices.md
101-101: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
105-105: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
106-106: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
107-107: Unordered list indentation
Expected: 2; Actual: 6
(MD007, ul-indent)
108-108: Unordered list indentation
Expected: 2; Actual: 6
(MD007, ul-indent)
109-109: Unordered list indentation
Expected: 2; Actual: 6
(MD007, ul-indent)
110-110: Unordered list indentation
Expected: 2; Actual: 6
(MD007, ul-indent)
111-111: Unordered list indentation
Expected: 2; Actual: 6
(MD007, ul-indent)
112-112: Unordered list indentation
Expected: 2; Actual: 6
(MD007, ul-indent)
113-113: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
114-114: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
115-115: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
116-116: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
117-117: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 12 12
Lines 2048 2048
=======================================
Hits 1897 1897
Misses 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added SyncEV Compact charger as a supported device with some of the tweaks to make it work well.
This should also work for the EVNet Discreet (https://www.evnet.bg/products/evnet-discreet/) but I don't have one to test with, so I didn't add it to the list ;)
Summary by CodeRabbit