Skip to content

Conversation

lbbrhzn
Copy link
Owner

@lbbrhzn lbbrhzn commented Feb 2, 2022

add the websocket close timout, ping timeout and ping interval to the config flow.
This can be used to finetune the connection with the charger if needed.
In addition it facilitates higher test coverage, by lowering the ping interval.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #350 (00bf907) into main (3de83f7) will increase coverage by 1.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   84.39%   85.53%   +1.13%     
==========================================
  Files          10       10              
  Lines        1160     1168       +8     
  Branches      171      171              
==========================================
+ Hits          979      999      +20     
+ Misses        111       99      -12     
  Partials       70       70              
Impacted Files Coverage Δ
custom_components/ocpp/config_flow.py 92.00% <ø> (ø)
custom_components/ocpp/api.py 78.21% <100.00%> (+1.79%) ⬆️
custom_components/ocpp/const.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de83f7...00bf907. Read the comment docs.

@lbbrhzn lbbrhzn merged commit 4862350 into main Feb 2, 2022
@lbbrhzn lbbrhzn deleted the make-websocket-timeout-configurable branch February 2, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant