trigger status notifications for all connectors

[lbbrhzn]

No description provided.

[codecov]

Codecov Report

Merging #365 (be2df07) into main (fc27bca) will increase coverage by 0.32%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   86.19%   86.51%   +0.32%     
==========================================
  Files          10       10              
  Lines        1188     1194       +6     
  Branches      174      177       +3     
==========================================
+ Hits         1024     1033       +9     
+ Misses         94       92       -2     
+ Partials       70       69       -1     

Impacted Files	Coverage Δ
custom_components/ocpp/api.py	79.91% <75.00%> (+0.59%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc27bca...be2df07. Read the comment docs.

[drc38]

Use self._metrics[cdet.connectors.value].value here instead?

[lbbrhzn]

It does need to be known, so the number of connectors should be retrieved before sending the triggers.

[drc38]

Perhaps in the @on(Action.StatusNotification) use the extra attributes of the connector status metric to handle statuses and errors for more than 1 connector?

[drc38]

Not sure what you mean. The functionality to store status and error code separately for main (id=0) and connector (id>0) is already in.

Is it for only 1 (ie 0 and 1) connector or will it handle say 0, 1 and 2?

[lbbrhzn]

Yes. We could support more than one connector, but to display the info in separate sensors we would need to know how many there at setup, or create the additional sensors on the fly, which is messy.

So, let's just keep the two sensors for connector=0 and connector=1 as is, and store additional info for other connectors in extra_attributes.

[drc38]

So, let's just keep the two sensors for connector=0 and connector=1 as is, and store additional info for other connectors in extra_attributes.

Agree 👍