Skip to content

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Feb 8, 2022

No description provided.

@drc38
Copy link
Collaborator Author

drc38 commented Feb 8, 2022

@lbbrhzn any ideas why in testing of the send_start_transaction the charge point's active_transactionId is not being updated to the Id provided by the cms server and instead reporting 1000 which is set at init?

@lbbrhzn
Copy link
Owner

lbbrhzn commented Feb 8, 2022

looks good to me, but tests are not passing yet !

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #382 (abe74c3) into main (a392eab) will increase coverage by 1.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   86.06%   87.83%   +1.76%     
==========================================
  Files          10       10              
  Lines        1206     1208       +2     
  Branches      181      181              
==========================================
+ Hits         1038     1061      +23     
+ Misses         96       83      -13     
+ Partials       72       64       -8     
Impacted Files Coverage Δ
custom_components/ocpp/api.py 81.93% <100.00%> (+2.67%) ⬆️
custom_components/ocpp/number.py 90.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a392eab...abe74c3. Read the comment docs.

@drc38
Copy link
Collaborator Author

drc38 commented Feb 8, 2022

@lbbrhzn, should be good to merge now. Some extra tests can now be added eg function to send clock meter data

@lbbrhzn
Copy link
Owner

lbbrhzn commented Feb 8, 2022

Looking good, nice test coverage!
Ok to merge now?

@lbbrhzn lbbrhzn merged commit 4cbac12 into main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Energy.Active.Import.Register since 03.02.2020 (V0.4.15 - V0.4.16)
2 participants