Use enums for measurands #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2021 21:44
|
🎉 HACS repository validator action summary 🎉 |
drc38
approved these changes
Jul 7, 2021
drc38
added a commit
that referenced
this pull request
Jul 8, 2021
ocpp: bug fix in measurands schema in #57
drc38
added a commit
that referenced
this pull request
Jul 9, 2021
drc38
added a commit
that referenced
this pull request
Jul 9, 2021
Revert "ocpp: bug fix in measurands schema in #57"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced measurand names with the constants provided by ocpp.v16.enums.Measurand.
Ideally, I would like to make api.py string literal free, this will make linting much more effective.
Currently you can only detect runtime if you've make an error in one of the strings...