Skip to content

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Jul 8, 2021

No description provided.

@drc38
Copy link
Collaborator Author

drc38 commented Jul 8, 2021

Test is now at a point it is testing the code but I'm not sure how to resolve this error? homeassistant.loader.IntegrationNotFound: Integration 'ocpp' not found.

@drc38 drc38 marked this pull request as ready for review July 8, 2021 09:33
@drc38 drc38 changed the title Add websockets to test env Add websockets, ocpp module dependencies to test env Jul 8, 2021
@drc38
Copy link
Collaborator Author

drc38 commented Jul 8, 2021

@lbbrhzn , I think I've gone as far as I can. Still a few more issues to resolve with the testing scripts

@lbbrhzn
Copy link
Owner

lbbrhzn commented Jul 8, 2021

thnx drc38! Can we remove the test that is still failing?

@@ -1,5 +1,8 @@
pip==21.1.3
pip<=20.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this <=20.3 coming from home assistant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was

@drc38 drc38 mentioned this pull request Jul 8, 2021
@drc38
Copy link
Collaborator Author

drc38 commented Jul 9, 2021

@lbbrhzn , tests are now running without error but failing as there is not sufficient code coverage

@lbbrhzn
Copy link
Owner

lbbrhzn commented Jul 9, 2021

Ok, good enough for now!

@lbbrhzn lbbrhzn merged commit 2b5d7b3 into lbbrhzn:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants