Skip to content

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Jul 16, 2021

Reverts #74

@github-actions
Copy link

🎉 HACS repository validator action summary 🎉
✅ The repository is not archived
✅ manifest.json file exist
✅ All required keys are present in manifest.json
✅ hacs.json has the 'name' key set
✅ The repository has a description
⚪ Ignored check: brands
✅ The repository has topics
✅ The repository has issues enabled
✅ This day ends with an 'y' (Friday)
✅ README.md exists
✅ Requirements validation
✅ Python wheels
✅ HACS load check

@drc38 drc38 merged commit 58c5674 into main Jul 16, 2021
@lbbrhzn
Copy link
Owner

lbbrhzn commented Jul 16, 2021

Why do we require that specific sqlachemy version?

@drc38
Copy link
Collaborator Author

drc38 commented Jul 16, 2021

pytest-homeassistant-custom-component 0.4.2 depends on sqlalchemy==1.4.17

@lbbrhzn
Copy link
Owner

lbbrhzn commented Jul 17, 2021

Is it possible to remove the requirement from requirements-dev.txt, and let pip auto detect this?

If not, we should add a comment to our requirements-dev.txt:

# pytest-homeassistant-custom-component 0.4.2 depends on sqlalchemy==1.4.17

@drc38
Copy link
Collaborator Author

drc38 commented Jul 17, 2021

Give it a go and see, I'm not familiar with how pip determines requirements

lbbrhzn pushed a commit that referenced this pull request Mar 1, 2025
* Allow multiple chargers per cs

* improve multidevice logic

* add config entry migration

* fix translations

* fix service tests and unloading

* Update manifest.json

* fix config migration when keys missing

* minor tidy ups

* fix id refs and add cp_id as identifier

* add minor version

* add minor_version to tests

* remove change of dr name

* fix up tests

* prevent entry duplicates

* Pending changes exported from your codespace

* patch discovery flow data in tests

* mock for discovery

* separate tests

* allow multiple chargers to connect

* update v201 test cpid

* fix platform cpid references

* fix v201 test config entry setup

* split v16 tests

* fix params for config setup fixture

* add hass to setup config entry

* use different port values

* fix port

* add port to setup

* fix dbl parenthesis

* shift cpid to after ws connection

* shift cpid for restore values

* rename nosub test

* Move services to each charger

* update test services to use cpid

* fix unload

* fix linting

* switch to central services

* update services.yaml

* Update services.yaml

* Update services.yaml

* Update services.yaml

* rework config flow

* fix linting

* Extra tidy ups

* add split

* fix linting

* fix test measurand input

* fix linting

* add test for dup discovery flow

* add invalid data test

* tidy up failed config flow  test

* use cp_id for migration

* update tests for cp_id and 2 charger connections

* fix on connect issues (#80)

* fix on connect issues

* fix entity state test

* Improve error handling for charger setup

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* add decorator for handle calls (#81)

* add decorator for handle calls

* fix linting

* fix linting

* fix linting

* revert device registry setup logic (#82)

* revert device registry setup logic

* fix services test

* fix ref

* get new cs in test

* fix linting

* remove id check

* amend config flow data updates

* avoid breaking change by setting default cp in service call

* add test for no devid

* fix linting, use empty str for devid

* use dummy str for devid

* switch devid required to false

* move devid call in try block

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants