Update current for 3 phase charger #93
Conversation
|
🎉 HACS repository validator action summary 🎉 |
| self._metrics[metric] = round(sum / 3, 1) | ||
| else: | ||
| self._metrics[metric] = round(sum, 1) | ||
| self._metrics[metric] = round(sum, 1) |
There was a problem hiding this comment.
Why round here? I assume it is for presentation purposes only, so maybe better do that in the sensor entity?
We could extend the upcoming Metric class to have a format, besides value and unit.
There was a problem hiding this comment.
Yes, only reason is presentation. Agree it would be better to handle format in the sensor. If sensor formats then other round functions can be removed from api also.
Switched to presenting overall current, rather than average phase current for consistency between single and 3 phase chargers, so that overall charger real power = power.factor x current.import x voltage.