Skip to content

Support unsigned bitshift operators #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2023
Merged

Support unsigned bitshift operators #2152

merged 3 commits into from
Jul 12, 2023

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Jul 11, 2023

fixes #2150

ubaidsk
ubaidsk commented Jul 11, 2023
View reviewed changes
@ubaidsk ubaidsk force-pushed the unsigned_bit_operators branch from c49b589 to 05ff79a Compare July 11, 2023 17:20
@ubaidsk ubaidsk requested a review from certik July 11, 2023 17:31
certik
certik approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that works. It's nice and clean. We can later further improve the C output, as needed. This should be correct.

@certik certik merged commit 851f878 into lcompilers:main Jul 12, 2023
@ubaidsk ubaidsk deleted the unsigned_bit_operators branch July 12, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for bitwise left and right shift operators in UnsignedInteger class
2 participants
@ubaidsk @certik