Skip to content

ASR: Fix expression as statement #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Jul 29, 2023

fixes #2215

@ubaidsk ubaidsk force-pushed the fix_expr_as_stmt branch from e3f0c35 to 3e183fd Compare July 29, 2023 11:05
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jul 29, 2023

Very helpful reviews @Smit-create. Thank you so much!

@ubaidsk ubaidsk requested a review from Smit-create July 29, 2023 11:06
@ubaidsk ubaidsk requested a review from certik July 29, 2023 11:31
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jul 29, 2023

There seems an approval on this PR. @certik I am merging this for the moment. I will work on further changes (if any) in a new PR.

@ubaidsk ubaidsk merged commit 9350838 into lcompilers:main Jul 29, 2023
@ubaidsk ubaidsk deleted the fix_expr_as_stmt branch July 29, 2023 11:34
@certik
Copy link
Contributor

certik commented Jul 29, 2023

Yes, I am happy that you review each others PRs and merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list.pop segmentation fault
3 participants