Skip to content

CPP: Fix list repeat issue 2221 #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 30, 2023
Merged

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Jul 30, 2023

@ubaidsk ubaidsk force-pushed the cpp_fix_issue_2221 branch 2 times, most recently from 69a4096 to 151a878 Compare July 30, 2023 07:12
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jul 30, 2023

Although the example shared here #2221 works in this PR, it seems there are more supports needed to make the CPP backend more usable/stable with lists.

@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jul 30, 2023

The changes in C, CPP backends in this PR are propagated to LFortran here lfortran/lfortran#2080. It seems to pass the tests there.

@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jul 30, 2023

Ready.

@ubaidsk ubaidsk requested a review from certik July 30, 2023 07:45
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Shouldn't you add a new test to test this new functionality?

@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Jul 30, 2023

Shouldn't you add a new test to test this new functionality?

I added a reference test. It seems cpp as a --backend is not yet supported in the lpython driver.

@ubaidsk ubaidsk force-pushed the cpp_fix_issue_2221 branch from 151a878 to 9860c3e Compare July 30, 2023 20:20
@ubaidsk ubaidsk enabled auto-merge July 30, 2023 20:24
@ubaidsk ubaidsk merged commit b3add2a into lcompilers:main Jul 30, 2023
@ubaidsk ubaidsk deleted the cpp_fix_issue_2221 branch August 4, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Generation Errors for C / C++ source code
2 participants