Skip to content

Revert "ASR: Support chained CompareOp" #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Revert "ASR: Support chained CompareOp" #2229

merged 1 commit into from
Jul 30, 2023

Conversation

Smit-create
Copy link
Collaborator

@Smit-create Smit-create commented Jul 30, 2023

Reverts #2213

Fixes #2227

@certik
Copy link
Contributor

certik commented Jul 30, 2023

@Smit-create is this ready?

@certik certik marked this pull request as ready for review July 30, 2023 13:38
@certik certik merged commit 0580c44 into main Jul 30, 2023
@certik certik deleted the revert-2213-i-2131 branch July 30, 2023 13:38
@certik
Copy link
Contributor

certik commented Jul 30, 2023

I am going to merge this, so that we can release a new version of LPython soon. It is important to ensure users don't start depending on this behavior, since it was incorrect and we would have to break it.

@Smit-create
Copy link
Collaborator Author

Yes, thanks for merging. It was ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible regression: x > y == z should not be allowed
2 participants