Skip to content

Conversation

@ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Aug 2, 2023

The existing names seem very long. They surpass the node width in the ASR Visualization.

Main Branch:
Screenshot 2023-08-02 at 6 20 15 PM

PR Branch:
Screenshot 2023-08-02 at 6 22 42 PM

@ubaidsk ubaidsk requested a review from certik August 2, 2023 12:56
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine.

@ubaidsk ubaidsk enabled auto-merge August 2, 2023 13:47
@ubaidsk ubaidsk merged commit e39f04f into lcompilers:main Aug 2, 2023
@ubaidsk ubaidsk deleted the shorter_names branch August 25, 2023 18:40
@ubaidsk ubaidsk restored the shorter_names branch August 25, 2023 18:40
@ubaidsk ubaidsk deleted the shorter_names branch August 25, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants