Skip to content

ASR: Merge create_CPtrToPointerFromArgs() and create_CPtrToPointer() #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Aug 26, 2023

This PR merges the functions create_CPtrToPointerFromArgs() and create_CPtrToPointer().

@ubaidsk ubaidsk requested a review from certik August 26, 2023 02:26
@ubaidsk ubaidsk force-pushed the asr_refactor_c_p_pointer2 branch from 6fb5200 to fd222f1 Compare August 26, 2023 09:56
@ubaidsk ubaidsk changed the title ASR: Refactor c_p_pointer() construction ASR: Merge create_CPtrToPointerFromArgs() and create_CPtrToPointer() Aug 26, 2023
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Aug 26, 2023

I removed two commits from this PR. I think/guess they can be further improved. I will explore and send them in a separate PR.

This PR is ready.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine.

@certik certik merged commit ab5d201 into lcompilers:main Aug 26, 2023
@ubaidsk ubaidsk deleted the asr_refactor_c_p_pointer2 branch August 26, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants